Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic template customisation #60

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

stufisher
Copy link
Contributor

This is a very simple method to allow templates to be customised, you maybe want something more complete in the long run, but this just lets you inject a custom template directory via an environment variable CUSTOM_TEMPLATE_PATH. It will fallback to the default location.

@MarcoMuellner
Copy link
Owner

Hey @stufisher, this is pretty neat! However, if we add this, there should be a part in the documentation that explains this. I also don't like the idea of having an environment variable, rather it should be an explicit option in the CLI interface. If those things are added, i'll gladly merge this :) Thanks for the contribution!

@stufisher
Copy link
Contributor Author

stufisher commented Jan 18, 2024

I had to update the pre-commit-hook isort version for compatability with a newer version of poetry (https://stackoverflow.com/questions/75269700/pre-commit-fails-to-install-isort-5-11-4-with-error-runtimeerror-the-poetry-co)

Mostly refactored as requested, seems to work

@MarcoMuellner
Copy link
Owner

Great, thank you for your contribution :)

@MarcoMuellner MarcoMuellner merged commit cc7bbf5 into MarcoMuellner:main Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants