Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDBF-980 - libvirt: Handle Major update from 11.8 to 12.0 #715

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

RazvanLiviuVarzaru
Copy link
Collaborator

The upgrade from 11.8.1 to 12.0.0 is legit but check_upgraded_versions() was not patched to handle it.

+ check_upgraded_versions
+ for file in /tmp/version.old /tmp/version.new
+ [[ -f /tmp/version.old ]]
+ for file in /tmp/version.old /tmp/version.new
+ [[ -f /tmp/version.new ]]
+ [[ major == \m\a\j\o\r ]]
++ cut -d . -f1
+ old_branch_digit=11
++ cut -d . -f2
+ old_major_digit=8
++ cut -d . -f1
+ new_branch_digit=12
++ cut -d . -f2
+ new_major_digit=0
+ (( old_branch_digit == 10 ))
+ old_major_digit_incr=9
+ (( old_major_digit_incr == new_major_digit ))
+ bb_log_err 'This does not look like a major upgrade:'
+ set +x
ERROR: This does not look like a major upgrade:
+ diff -u /tmp/version.old /tmp/version.new
--- /tmp/version.old	2025-02-20 03:19:38.015106234 -0500
+++ /tmp/version.new	2025-02-20 03:19:54.479195336 -0500
@@ -1 +1 @@
-11.8.1
+12.0.0
+ exit 1

@RazvanLiviuVarzaru RazvanLiviuVarzaru marked this pull request as ready for review February 20, 2025 09:47
The upgrade from 11.8.1 to 12.0.0 is legit but check_upgraded_versions() was not patched to handle it.
```
+ check_upgraded_versions
+ for file in /tmp/version.old /tmp/version.new
+ [[ -f /tmp/version.old ]]
+ for file in /tmp/version.old /tmp/version.new
+ [[ -f /tmp/version.new ]]
+ [[ major == \m\a\j\o\r ]]
++ cut -d . -f1
+ old_branch_digit=11
++ cut -d . -f2
+ old_major_digit=8
++ cut -d . -f1
+ new_branch_digit=12
++ cut -d . -f2
+ new_major_digit=0
+ (( old_branch_digit == 10 ))
+ old_major_digit_incr=9
+ (( old_major_digit_incr == new_major_digit ))
+ bb_log_err 'This does not look like a major upgrade:'
+ set +x
ERROR: This does not look like a major upgrade:
+ diff -u /tmp/version.old /tmp/version.new
--- /tmp/version.old	2025-02-20 03:19:38.015106234 -0500
+++ /tmp/version.new	2025-02-20 03:19:54.479195336 -0500
@@ -1 +1 @@
-11.8.1
+12.0.0
+ exit 1
```
@RazvanLiviuVarzaru RazvanLiviuVarzaru merged commit 95c9f0c into MariaDB:dev Feb 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants