-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy portfolio on netlify #2593
base: master
Are you sure you want to change the base?
Deploy portfolio on netlify #2593
Conversation
Quick link here |
Reference Documentation Site in Question: https://markbind.org/userGuide/templates.html Something doesn't seem right... The buttons represent These are actually quick deploy links provided by MarkBind, that create a repository for you and deploy in a single click. In fact, this highlights that the Also the site https://markbind-template-portfolio.netlify.app/ looks broken on my end too. (Needs to be investigated). I have a few suggestions:
These suggestions could be made out into separate issues as well to be appropriate handled and tracked. Cheers 👍 |
Great catch on the misleading "Deploy to Netifly" label. I also agree that we should add a seperate column about sample deployment.👍 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2593 +/- ##
=======================================
Coverage 51.86% 51.86%
=======================================
Files 127 127
Lines 5474 5474
Branches 1201 1201
=======================================
Hits 2839 2839
Misses 2340 2340
Partials 295 295 ☔ View full report in Codecov by Sentry. |
What is the purpose of this pull request?
Fixes #2418
Overview of changes:
Anything you'd like to highlight/discuss:
The porfolio site is publicly accessible using the following url https://markbind-template-portfolio.netlify.app/.
Testing instructions:
markbind s
i. Click on the
USER GUIDE
tab located at the top of the home pageii. Click on the
Templates
tab located at the side, underWorking with Sites
Proposed commit message: (wrap lines at 72 characters)
Deploy portfolio on Netlify
Checklist: ☑️
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major
,r.Minor
,r.Patch
.Breaking change release note preparation (if applicable):