feature/overhaul #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ignored .DS_Store files
- Added test placeholders - Updated README with revised install instructions
Set max line length to 99 because it’s 2018.
The existing codebase used single-quotes, so they’re being preserved for now until after unit-testing is under control and the actual rewrite commences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A modernization of GoonAuth2, reflecting updates to its dependencies and modern Python dev practices within the last three years.
Falcon has been upgraded to v1.4.1, the latest available. I've also pegged Python to v3.6, and suggest using the latest Redis v5.0.0.
Linting and EditorConfig support have been added to ensure general code quality.
Full test coverage has also been added. Current coverage is at 100%.
I pulled in mockredispy and hand-patched it because it didn't respect
decode_responseand was handing out bytestrings. This introduced unnecessary complexity into the unit tests and the codebase itself. The library can be removed from this project if this PR (or one like it) ever gets merged in:locationlabs/mockredis#124