output consistency: remove string_agg and array_agg without ordering (#29446)

Author: nrainer-materialize

misc/python/materialize/output_consistency/ignore_filter/internal_output_inconsistency_ignore_filter.py

@@ -39,7 +39,6 @@
 )
 from materialize.output_consistency.operation.operation import (
     DbFunction,
-    DbFunctionWithCustomPattern,
     DbOperation,
     DbOperationOrFunction,
 )
@@ -112,13 +111,6 @@ def _matches_problematic_function_invocation(
             ):
                 return YesIgnore("#15186")
 
-        if db_function.function_name_in_lower_case in {
-            "array_agg",
-            "string_agg",
-        } and not isinstance(db_function, DbFunctionWithCustomPattern):
-            # The unordered variants are to be ignored.
-            return YesIgnore("#19832")
-
         return NoIgnore()
 
     def _matches_problematic_operation_invocation(

misc/python/materialize/output_consistency/input_data/operations/aggregate_operations_provider.py

@@ -145,17 +145,6 @@
     ),
 )
 
-AGGREGATE_OPERATION_TYPES.append(
-    DbFunction(
-        "string_agg",
-        [StringOperationParam(), StringOperationParam()],
-        StringReturnTypeSpec(),
-        is_aggregation=True,
-        relevance=OperationRelevance.LOW,
-        comment="without ordering",
-    ),
-)
-
 AGGREGATE_OPERATION_TYPES.append(
     DbFunctionWithCustomPattern(
         "string_agg",
@@ -168,6 +157,5 @@
         StringReturnTypeSpec(),
         is_aggregation=True,
         relevance=OperationRelevance.LOW,
-        comment="with ordering",
     ),
 )

misc/python/materialize/output_consistency/input_data/operations/array_operations_provider.py

@@ -169,23 +169,13 @@
         BooleanReturnTypeSpec(),
     )
 )
-ARRAY_OPERATION_TYPES.append(
-    DbFunction(
-        "array_agg",
-        [AnyOperationParam()],
-        ArrayReturnTypeSpec(array_value_type_category=DataTypeCategory.DYNAMIC),
-        is_aggregation=True,
-        comment="without ordering",
-    ),
-)
 ARRAY_OPERATION_TYPES.append(
     DbFunctionWithCustomPattern(
         "array_agg",
         {2: "array_agg($ ORDER BY row_index, $)"},
         [AnyOperationParam(), SameOperationParam(index_of_previous_param=0)],
         ArrayReturnTypeSpec(array_value_type_category=DataTypeCategory.DYNAMIC),
         is_aggregation=True,
-        comment="with ordering",
     ),
 )
 ARRAY_OPERATION_TYPES.append(

misc/python/materialize/postgres_consistency/ignore_filter/pg_inconsistency_ignore_filter.py

@@ -232,15 +232,6 @@ def _matches_problematic_function_invocation(
         expression: ExpressionWithArgs,
         all_involved_characteristics: set[ExpressionCharacteristics],
     ) -> IgnoreVerdict:
-        inconsistent_value_ordering_functions = ["array_agg", "string_agg"]
-        if (
-            db_function.function_name_in_lower_case
-            in inconsistent_value_ordering_functions
-            # only exclude unordered variant
-            and "ORDER BY" not in db_function.to_pattern(db_function.max_param_count)
-        ):
-            return YesIgnore("inconsistent ordering, not an error")
-
         if db_function.function_name_in_lower_case == "jsonb_pretty":
             return YesIgnore("Accepted")