Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapter: Move mz_aclitem to mz_catalog #23862

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

jkosh44
Copy link
Contributor

@jkosh44 jkosh44 commented Dec 13, 2023

This commit updates the schema of mz_aclitem from mz_internal to mz_catalog. Due to
https://github.com/MaterializeInc/database-issues/issues/7154, mz_aclitem has actually always been in the pg_catalog schema, and will remain in the pg_catalog schema after this change. However, the type has pretended to be in the mz_internal schema for long enough that it is now stable, so it's ready to pretend to be in the mz_catalog schema.

Motivation

This PR refactors existing code.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:
    • There are no user-facing behavior changes.

This commit updates the schema of mz_aclitem from mz_internal to
mz_catalog. Due to
https://github.com/MaterializeInc/materialize/issues/23833, mz_aclitem
has actually always been in the pg_catalog schema, and will remain in
the pg_catalog schema after this change. However, the type has
pretended to be in the mz_internal schema for long enough that it is
now stable, so it's ready to pretend to be in the mz_catalog schema.
@jkosh44 jkosh44 marked this pull request as ready for review December 13, 2023 16:42
@jkosh44 jkosh44 requested a review from a team as a code owner December 13, 2023 16:42
@jkosh44 jkosh44 requested a review from maddyblue December 13, 2023 16:42
@jkosh44 jkosh44 merged commit 0823aac into MaterializeInc:main Dec 14, 2023
4 checks passed
@jkosh44 jkosh44 deleted the mz-acl-item-schema branch December 14, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants