Add preliminary support for other cloud providers to orchestratord #30534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-hunt-materialize
force-pushed
the
orchestratord_other_cloud_providers
branch
4 times, most recently
from
eb54197 to
1a5a4f3
Compare
Changes orchestratord to use the CloudProvider used by the catalog, to reduce duplication and eliminate the possibility of incompatibilities between them. Adds preliminary support for other cloud providers. Does not add any special handling of them, but accepts GCP, Azure, and Generic cloud providers. In the future, we may want to expand our support for these to include their equivalent of IAM roles, to support advanced features such as non-password-based access to persist buckets or assuming roles, but that is all out of scope for now.
alex-hunt-materialize
force-pushed
the
orchestratord_other_cloud_providers
branch
from
1a5a4f3 to
d0c0e38
Compare
jkosh44
approved these changes
Nov 19, 2024
alex-hunt-materialize
deleted the
orchestratord_other_cloud_providers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds preliminary support for other cloud providers to orchestratord.
Does not add any special handling of them, but accepts GCP, Azure, and Generic cloud providers.
In the future, we may want to expand our support for these to include their equivalent of IAM roles, to support advanced features such as non-password-based access to persist buckets or assuming roles, but that is all out of scope for now.
Motivation
With self-hosted, our customers may run this in other cloud providers.
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.