adapter: don't block the Coordinator on cluster status events #31070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParkMyCar
commented
Jan 16, 2025
src/adapter/src/coord.rs
Outdated
| @@ -3477,12 +3477,29 @@ impl Coordinator { | |||
| } | |||
|
|
|||
| /// Publishes a notice message to all sessions. | |||
| pub(crate) fn broadcast_notice(&self, notice: AdapterNotice) { | |||
| pub fn broadcast_notice(&self, notice: AdapterNotice) { | |||
There was a problem hiding this comment.
I made this pub so it wouldn't emit an unused code warning. It felt like a good API to keep around, happy to just remove it if folks think that's better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating some spikes in p99 message duration in the Coordinator, I noticed that we currently block on a builtin table write when receiving a status update for a cluster.
This PR refactors the code so we wait for the builtin write to complete in a
tokio::task, and then notify sessions.Motivation
Improve P99 latencies for Coordinator messages
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.