-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable activity log for self managed #31403
Open
SangJunBak
wants to merge
1
commit into
main
Choose a base branch
from
jun/disable-activity-log
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+16
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SangJunBak
force-pushed
the
jun/disable-activity-log
branch
from
February 7, 2025 17:53
f6df7e0
to
683f4a3
Compare
SangJunBak
force-pushed
the
jun/disable-activity-log
branch
from
February 7, 2025 19:09
683f4a3
to
709e163
Compare
SangJunBak
added
the
lts-backport-v25.1
Needs to be backported into the v25.1 LTS release
label
Feb 7, 2025
SangJunBak
force-pushed
the
jun/disable-activity-log
branch
from
February 7, 2025 20:38
709e163
to
8eba53d
Compare
SangJunBak
force-pushed
the
jun/disable-activity-log
branch
from
February 7, 2025 20:42
8eba53d
to
3fb823b
Compare
@jubrad Figured you'd be the best person to review this since it seems like versioning is top of mind! Added you to the Console equivalent PR too https://github.com/MaterializeInc/console/pull/3683. Some questions:
|
SangJunBak
commented
Feb 7, 2025
@@ -15,7 +15,7 @@ | |||
# deployed to production, but the version needs to be bumped whenever features | |||
# that the console depends upon are removed (to a version of the console that | |||
# doesn't depend on those features). | |||
FROM materialize/console:25.1.0-beta.3 AS console | |||
FROM materialize/console:25.1.0-beta.4 AS console |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Emulator has statement logging disabled by default already
SangJunBak
force-pushed
the
jun/disable-activity-log
branch
from
February 7, 2025 21:42
3fb823b
to
9b8e765
Compare
SangJunBak
force-pushed
the
jun/disable-activity-log
branch
from
February 7, 2025 21:47
9b8e765
to
e544c6d
Compare
jubrad
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was able to test this by using
bin/mzimage acquire orchestratord
to get a new image then pointing the helm chart at itMotivation
Fixes https://github.com/MaterializeInc/cloud/issues/10755
Dependent on https://github.com/MaterializeInc/console/pull/3683 being merged and the tag being pushed
Tips for reviewer
Checklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way), then it is tagged with aT-proto
label.