Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable activity log for self managed #31403

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SangJunBak
Copy link
Contributor

@SangJunBak SangJunBak commented Feb 7, 2025

Was able to test this by using bin/mzimage acquire orchestratord to get a new image then pointing the helm chart at it

Motivation

Fixes https://github.com/MaterializeInc/cloud/issues/10755

Dependent on https://github.com/MaterializeInc/console/pull/3683 being merged and the tag being pushed

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@SangJunBak SangJunBak force-pushed the jun/disable-activity-log branch from f6df7e0 to 683f4a3 Compare February 7, 2025 17:53
@SangJunBak SangJunBak changed the base branch from lts-v0.130 to main February 7, 2025 17:53
@SangJunBak SangJunBak force-pushed the jun/disable-activity-log branch from 683f4a3 to 709e163 Compare February 7, 2025 19:09
@SangJunBak SangJunBak requested a review from a team February 7, 2025 19:14
@SangJunBak SangJunBak marked this pull request as ready for review February 7, 2025 19:15
@SangJunBak SangJunBak added the lts-backport-v25.1 Needs to be backported into the v25.1 LTS release label Feb 7, 2025
@SangJunBak SangJunBak marked this pull request as draft February 7, 2025 19:57
@SangJunBak SangJunBak force-pushed the jun/disable-activity-log branch from 709e163 to 8eba53d Compare February 7, 2025 20:38
@SangJunBak SangJunBak requested a review from jubrad February 7, 2025 20:38
@SangJunBak SangJunBak marked this pull request as ready for review February 7, 2025 20:38
@SangJunBak SangJunBak force-pushed the jun/disable-activity-log branch from 8eba53d to 3fb823b Compare February 7, 2025 20:42
@SangJunBak
Copy link
Contributor Author

@jubrad Figured you'd be the best person to review this since it seems like versioning is top of mind! Added you to the Console equivalent PR too https://github.com/MaterializeInc/console/pull/3683. Some questions:

  • Given I updated deployment.yaml, do I need to update the helm chart version?
  • In this commit, the tag is set to v0.133.0-dev.0 for orchestratord. When we backport, is the plan to update this value in values.yaml accordingly?
  • On the Console end, instead of backporting the change in the PR, I was just going to fast forward the LTS branch to current main given they're both backwards compatible with each other then pushing 25.1.0-beta.4 to dockerhub. Is that ok?

@@ -15,7 +15,7 @@
# deployed to production, but the version needs to be bumped whenever features
# that the console depends upon are removed (to a version of the console that
# doesn't depend on those features).
FROM materialize/console:25.1.0-beta.3 AS console
FROM materialize/console:25.1.0-beta.4 AS console
Copy link
Contributor Author

@SangJunBak SangJunBak Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Emulator has statement logging disabled by default already

@SangJunBak SangJunBak force-pushed the jun/disable-activity-log branch from 3fb823b to 9b8e765 Compare February 7, 2025 21:42
@SangJunBak SangJunBak force-pushed the jun/disable-activity-log branch from 9b8e765 to e544c6d Compare February 7, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lts-backport-v25.1 Needs to be backported into the v25.1 LTS release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants