Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[persist] Allow disabling the sink progress collection optimization #31464

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

bkirwi
Copy link
Contributor

@bkirwi bkirwi commented Feb 11, 2025

Motivation

Discussed live: easy and possibly useful.

Tips for reviewer

Note that this doesn't allow disabling the creation etc. of the new shard or the writes in the Kafka sink itself, since that involves wider changes to the controller that are hard to separate out. Still, this may be useful in the case where that stuff is fine but the actual optimization itself is unsafe...

I still have a couple TODOs I'd like to get to ~soonish, but I'll split those out to a separate PR to increase the odds this one merges by the release cut.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@bkirwi bkirwi changed the title [persist] Followups for the sink progress collection [persist] Allow disabling the sink progress collection optimization Feb 13, 2025
@bkirwi bkirwi marked this pull request as ready for review February 13, 2025 19:45
@bkirwi bkirwi requested a review from a team as a code owner February 13, 2025 19:45
@bkirwi bkirwi requested a review from ParkMyCar February 13, 2025 21:23
Copy link
Member

@ParkMyCar ParkMyCar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding this flag!

@bkirwi bkirwi merged commit 3ba1844 into MaterializeInc:main Feb 13, 2025
80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants