storage: allow singleton sources on multi-replica clusters #31479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Petros Angelatos <[email protected]>
This will make it easier to change how we track the data inside Instance.
aljoscha
force-pushed
the
storage-allow-singleton-sources-on-multi-replica-clusters
branch
from
f0ee30b to
cc5e6b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is stacked on #31227, so only the last few commits are relevant for singleton sources.
NOTE: There is still murkiness around
active_copiesin the controller itself, which have to be fixed before we can merge!Opening this PR early to so I can run nightly. @def- With this, all sources should now work on multi-replica clusters, I imagine there is tests that you would like to change?