Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "ci: Move cargo test to Hetzner (and disable real-S3 tests)" #31486

Closed
wants to merge 1 commit into from
+3 −6
Closed

Revert "ci: Move cargo test to Hetzner (and disable real-S3 tests)" #31486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ci/test/pipeline.template.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,10 +287,12 @@ steps:
# some tests run into stack overflows
RUST_MIN_STACK: "4194304"
plugins:
- ./ci/plugins/scratch-aws-access: ~
- ./ci/plugins/mzcompose:
composition: cargo-test
agents:
queue: hetzner-x86-64-dedi-32cpu-128gb
# Because of scratch-aws-access
queue: builder-linux-aarch64-mem

- id: testdrive
label: "Testdrive"
Expand Down
3 changes: 0 additions & 3 deletions src/aws-util/src/s3_uploader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,6 @@ mod tests {
#[mz_ore::test(tokio::test(flavor = "multi_thread"))]
#[cfg_attr(coverage, ignore)] // https://github.com/MaterializeInc/database-issues/issues/5586
#[cfg_attr(miri, ignore)] // error: unsupported operation: can't call foreign function `TLS_method` on OS `linux`
#[ignore] // TODO: Reenable against minio so it can run locally
async fn multi_part_upload_success() -> Result<(), S3MultiPartUploadError> {
let sdk_config = defaults().load().await;
let (bucket, key) = match s3_bucket_key_for_test() {
Expand Down Expand Up @@ -431,7 +430,6 @@ mod tests {
#[mz_ore::test(tokio::test(flavor = "multi_thread"))]
#[cfg_attr(coverage, ignore)] // https://github.com/MaterializeInc/database-issues/issues/5586
#[cfg_attr(miri, ignore)] // error: unsupported operation: can't call foreign function `TLS_method` on OS `linux`
#[ignore] // TODO: Reenable against minio so it can run locally
async fn multi_part_upload_buffer() -> Result<(), S3MultiPartUploadError> {
let sdk_config = defaults().load().await;
let (bucket, key) = match s3_bucket_key_for_test() {
Expand Down Expand Up @@ -490,7 +488,6 @@ mod tests {
#[mz_ore::test(tokio::test(flavor = "multi_thread"))]
#[cfg_attr(coverage, ignore)] // https://github.com/MaterializeInc/database-issues/issues/5586
#[cfg_attr(miri, ignore)] // error: unsupported operation: can't call foreign function `TLS_method` on OS `linux`
#[ignore] // TODO: Reenable against minio so it can run locally
async fn multi_part_upload_no_data() -> Result<(), S3MultiPartUploadError> {
let sdk_config = defaults().load().await;
let (bucket, key) = match s3_bucket_key_for_test() {
Expand Down
1 change: 0 additions & 1 deletion src/persist/src/s3.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1094,7 +1094,6 @@ mod tests {
#[mz_ore::test(tokio::test(flavor = "multi_thread"))]
#[cfg_attr(coverage, ignore)] // https://github.com/MaterializeInc/database-issues/issues/5586
#[cfg_attr(miri, ignore)] // error: unsupported operation: can't call foreign function `TLS_method` on OS `linux`
#[ignore] // TODO: Reenable against minio so it can run locally
async fn s3_blob() -> Result<(), ExternalError> {
let config = match S3BlobConfig::new_for_test().await? {
Some(client) => client,
Expand Down
1 change: 0 additions & 1 deletion src/storage-operators/src/s3_oneshot_sink/pgcopy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,6 @@ mod tests {
#[mz_ore::test(tokio::test(flavor = "multi_thread"))]
#[cfg_attr(coverage, ignore)] // https://github.com/MaterializeInc/database-issues/issues/5586
#[cfg_attr(miri, ignore)] // error: unsupported operation: can't call foreign function `TLS_method` on OS `linux`
#[ignore] // TODO: Reenable against minio so it can run locally
async fn test_multiple_files() -> Result<(), anyhow::Error> {
let sdk_config = mz_aws_util::defaults().load().await;
let (bucket, path) = match s3_bucket_path_for_test() {
Expand Down