adapter: turmoil chaos test for builtin schema migrations #34110
+647
−152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
teskje
force-pushed
the
builtin-item-migration-turmoil
branch
from
b6d0f5f to
81bd870
Compare
This commit introduces `PersistClientCache::new_for_turmoil`, as a way to use persist in turmoil tests. In particular, this disables the isolated runtime. Tasks that would be spawned there are instead spawned in the current runtime. The method is gated behind a new "turmoil" feature.
teskje
force-pushed
the
builtin-item-migration-turmoil
branch
from
81bd870 to
39a7377
Compare
5 tasks
This commit reorganizes the builtin schema migration code by pulling all `Transaction` handling into the top-level `run` function. `Migration` becomes unaware of the existing of the `Transaction` and instead returns a `MigrationRunResult` that informs the caller about the changes that need to be applied. The reason for doing this is that it makes it easier to test the core migration code. In tests it's difficult to construct a `Transaction` object, and with this change we don't have to do that anymore, as long as we're invoking `Migration::run` directly.
This commit adds a turmoil-based chaos test for builtin schema migrations. It spawns a bunch of processes at different versions, defines some random builtin schema changes, and then performs migrations through all versions. For added chaos, process are randomly restarted all the time.
teskje
force-pushed
the
builtin-item-migration-turmoil
branch
from
39a7377 to
c98c108
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a turmoil-based chaos test for builtin schema migrations. It spawns a bunch of processes at different versions, defines some random builtin schema changes, and then performs migrations through all versions. For added chaos, processes are randomly restarted all the time.
(Includes commit from #34148.)
Motivation
Tips for reviewer
The first commit adjusts the builtin schema migration code by pulling the
Transactionhandling out of the core migration logic. Turns out that it isn't easy to construct aTransactionin tests, so pulling it to the edge makes the test code simpler.Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.