-
Notifications
You must be signed in to change notification settings - Fork 482
publish helm chart information when bumping versions #34114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alex-hunt-materialize
wants to merge
1
commit into
MaterializeInc:docs-upcoming-v26.0.0
Choose a base branch
from
alex-hunt-materialize:helm_docs
base: docs-upcoming-v26.0.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+444
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As an FYI ... we're missing the title field here, which is why it doesn't render.
Also, we can probably simplify this:
This way, if we need to tweak the front matter, the script doesn't need to change.
And, I think we probably want to clean up the readme a bit? and I talked with @jubrad yesterday ... w.r.t. the the config options ... we currently have them displayed both as a table with the param and default value and a section below that has more description. https://materialize.com/docs/installation/configuration/#configure-the-materialize-operator ... the reason for this is to avoid having users scroll.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh ... and now reviewing the CRD reference generation page, I should meantion, @jubrad it doesn't havae to be .yml ... if it's easier for you all to use array of json docs, that's fine too (we'll just need to tweak the short codes)