refactor: Restructure project to a more conventional Android architecture #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zt64
suggested changes
Jul 15, 2025
| - name: Download Schema via Introspection | ||
| run: | | ||
| chmod +x ./gradlew && ./gradlew :api:downloadServiceApolloSchemaFromIntrospection | ||
| chmod +x ./gradlew |
Contributor
There was a problem hiding this comment.
You dont need to run chmod +x gradlew. It already has executable flag set
build-logic/convention/src/main/kotlin/dev/materii/gloom/KotlinAndroid.kt
Outdated
Show resolved
Hide resolved
build-logic/convention/src/main/kotlin/dev/materii/gloom/KotlinAndroid.kt
Outdated
Show resolved
Hide resolved
core/graphql/src/main/kotlin/dev/materii/gloom/core/graphql/response/GraphQLResponse.kt
Show resolved
Hide resolved
|
|
||
| import com.apollographql.apollo.api.Optional | ||
|
|
||
| fun <T> T?.toOptional(): Optional<T> = Optional.presentIfNotNull(this) No newline at end of file |
Member
Author
There was a problem hiding this comment.
i get yelled at for it not having significant performance benefits
| rootProject.name = "Gloom" | ||
| include(":app") | ||
|
|
||
| enableFeaturePreview("TYPESAFE_PROJECT_ACCESSORS") |
Contributor
There was a problem hiding this comment.
I think this should be at the very top, since it's enabling a global feature
settings.gradle.kts
Outdated
| } | ||
|
|
||
| rootProject.name = "Gloom" | ||
| include(":app") |
- Switch to jvmToolchain - Allow using existing plugin declarations from version catalog as compileOnly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.