This repository was archived by the owner on May 30, 2019. It is now read-only.
Fixing some things... #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ghostsquad .. I actually started just looking at Pester for this exact reason. I'd love for you to make the first commit for the Pester tests so I can see the direction I should be going in with them :) |
|
@ghostsquad are you ok with making a feature request and closing this pull request? |
|
@MattHodge, ya I'll make a feature request. Please merge what you feel is appropriate from this pull request. Some of the throws make sense, as you suggested though, not all of them. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, I should have wrote tests first! I'll work on that next so that future commits can be validated. I was thinking Pester for a test framework. Or writing this in C# and testing using Xunit.