Clone all submodules without groovy handlers #237
+20
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Groovy doesn't actually enforce this restriction, but this helps make clear that checkout_repo() is the intended entrypoint. Signed-off-by: Bence Szépkúti <[email protected]>
List and clone all submodules that are still unitialized after all the handlers have run. Signed-off-by: Bence Szépkúti <[email protected]>
bensze01
force-pushed
the
dev/bensze01/submodules
branch
from
d45f21c to
f32f0d3
Compare
bensze01
added
enhancement
gilles-peskine-arm
previously approved these changes
Dec 9, 2025
Contributor
gilles-peskine-arm
left a comment
gilles-peskine-arm
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix
github-project-automation
bot
moved this to In Development
in Roadmap pull requests (new board)
ronald-cron-arm
moved this from In Development
to In Review
in Roadmap pull requests (new board)
ronald-cron-arm
requested changes
Dec 11, 2025
github-project-automation
bot
moved this from In Review
to In Development
in Roadmap pull requests (new board)
Replace use of sed with awk for easier readability. Signed-off-by: Bence Szépkúti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List and clone all submodules that are still unitialized after all the handlers have run.
Required by Gilles's PR adding mldsa-native as a submodule.
CI runs:
all-core.sh, and unlike in https://ci.trustedfirmware.org/job/mbed-tls-tf-psa-crypto-multibranch/job/PR-593-head/1/ with no workaround)