Skip to content

Conversation

@HaniAmmar
Copy link

@HaniAmmar HaniAmmar commented Oct 15, 2025

Description

This pull request introduces new public APIs that allow external components (such as Kernel TLS) to access TLS traffic secrets and sequence numbers in a controlled manner.
These additions make it possible to implement KTLS handover or other advanced integrations without modifying Mbed TLS internals.

See: #10425

PR checklist

  • changelog provided
  • development PR provided
  • TF-PSA-Crypto PR — not required (no changes)
  • framework PR — not required (no changes)
  • 3.6 PR — planned for backport after this merge
  • tests provided

@davidhorstmann-arm davidhorstmann-arm moved this to Triage in in Community Oct 17, 2025
@gilles-peskine-arm gilles-peskine-arm added enhancement size-m Estimated task size: medium (~1w) component-tls needs-ci Needs to pass CI tests priority-medium Medium priority - this can be reviewed as time permits labels Oct 30, 2025
@gilles-peskine-arm
Copy link
Contributor

Thank you very much for contributing this feature! Due to the size, I'm afraid it might take a while for us to review it. Unfortunately, review bandwidth is a major bottleneck for us.

A small note: this is a new feature of significant size, so we will not backport it to a long-time support branch.

@davidhorstmann-arm
Copy link
Contributor

Hi @HaniAmmar, thanks so much for contributing this!

We've looked at it and discussed internally. We won't have enough bandwidth to review this whole PR at once because it is quite large. Would you mind splitting it out into 2 smaller PRs, one containing the new functions and tests and the other adding the example program?

One other minor thing - I notice that you've written test functions with all of the possible test cases inside them - would you be able to refactor that so that the test functionality is in the .function file and the different sets of test data are in the .data file? See here for an explanation of our test framework. You can also use the magic data_t type to supply a hex string to a test function which appears as a buffer of binary data to the test function. If you have any questions feel free to ask for help!

Once the PR is split we can schedule it for review on the community board.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component-tls enhancement needs-ci Needs to pass CI tests priority-medium Medium priority - this can be reviewed as time permits size-m Estimated task size: medium (~1w)

Projects

Status: Triage in

Development

Successfully merging this pull request may close these issues.

3 participants