Migrate configuration-crypto components to cmake #10507
Open
+141
−87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minosgalanakis
added
needs-work
needs-ci
ronald-cron-arm
changed the title
ronald-cron-arm
changed the title
minosgalanakis
force-pushed
the
rework/component-configuration-crypto-cmake
branch
2 times, most recently
from
78aec57 to
a39dc79
Compare
minosgalanakis
force-pushed
the
rework/component-configuration-crypto-cmake
branch
3 times, most recently
from
9a7e3aa to
006d758
Compare
Contributor
Author
minosgalanakis
force-pushed
the
rework/component-configuration-crypto-cmake
branch
2 times, most recently
from
35af1d8 to
dab67bd
Compare
minosgalanakis
added
needs-review
Migrate all straightfoward components from using $ASAN_CFLAGS to CMAKE_BUILD_TYPE:String=Asan Signed-off-by: Minos Galanakis <[email protected]>
…o cmake Optimization for size (-Os) is required. Signed-off-by: Minos Galanakis <[email protected]>
…r_accel_ec to cmake Compilation flags, and spe include directories have been adjusted Signed-off-by: Minos Galanakis <[email protected]>
…onents to cmake - By default all unspecified build-type components should be release - CMAKE_BUILD_TYPE:String=Release enables the following CFLAGS: "-O2 -Werror -Wall -Wextra" Signed-off-by: Minos Galanakis <[email protected]>
…se components to cmake Moved the following components to CMAKE_BUILD_TYPE:String=Release and adjusted the include paths for cmake: * component_build_psa_crypto_spm * component_test_tfm_config_no_p256m Signed-off-by: Minos Galanakis <[email protected]>
…d_light_only to cmake Use compilation directory for object discovery in out-of-source CMake builds. Signed-off-by: Minos Galanakis <[email protected]>
…_BUILD_TYPE:String=None Improve compilation flag granularity by disabling CMAKE_BUILD_TYPE defaults and asserting test-specific flags manually. Signed-off-by: Minos Galanakis <[email protected]>
Signed-off-by: Minos Galanakis <[email protected]>
The original make -C tests, contains a perl inliner to generate the alt-headers. Replicated that logic in sed regex. Signed-off-by: Minos Galanakis <[email protected]>
Update the previously modified component to use consistent syntax: * make -> cmake --build . * make test -> ctest * Removed redudant CC=$ASAN_CC for BUILD_TYPE:String=Asan Signed-off-by: Minos Galanakis <[email protected]>
minosgalanakis
force-pushed
the
rework/component-configuration-crypto-cmake
branch
from
51266d8 to
61f5ab1
Compare
ronald-cron-arm
removed
the
needs-reviewer
github-project-automation
bot
moved this to In Development
in Roadmap pull requests (new board)
ronald-cron-arm
moved this from In Development
to In Review
in Roadmap pull requests (new board)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates a series of components from the configuration-crypto on mbedtls to cmake. One of many pr's required for #10472
PR checklist
Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.