Backport 3.6: Fix AESCE regression with Clang due to inclusion order changes #10538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As indicated in a comment, with older Clang, we need to define `__ARM_FEATURE_CRYPTO` before we include `arm_neon.h`, which is done via `common.h`. 4c44990 accidentally broke this. Fix it, while taking care not to include another header before `common.h`. Signed-off-by: Gilles Peskine <[email protected]>
Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
added
bug
needs-review
github-project-automation
bot
moved this to In Development
in Roadmap pull requests (new board)
4 tasks
davidhorstmann-arm
approved these changes
Dec 11, 2025
Contributor
davidhorstmann-arm
left a comment
davidhorstmann-arm
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Mbed-TLS/TF-PSA-Crypto#601, a regression introduced by #10526 which got merged recently.
PR checklist
clang-15 -target aarch64-linux-gnu --sysroot /usr/aarch64-linux-gnu -I include -c library/aesce.c(see the issue description for more details). I tested locally as far back as clang 7. Clang 6 and earlier have a different problem: Build failure of aesce.c with ancient Clang TF-PSA-Crypto#604