Android: Statically link ZenLib to MediaInfoLib#1242
Merged
JeromeMartinez merged 3 commits intoMediaArea:masterfrom Mar 12, 2026
Merged
Android: Statically link ZenLib to MediaInfoLib#1242JeromeMartinez merged 3 commits intoMediaArea:masterfrom
JeromeMartinez merged 3 commits intoMediaArea:masterfrom
Conversation
Member
Right, we didn't think to that but for this case it is better. |
Member
|
Looks fine (and 50 KiB smaller). |
cjee21
force-pushed
the
android
branch
2 times, most recently
from
c80fc92 to
318ae08
Compare
Collaborator
Author
|
I changed to use the newly added CMake config instead of relying on cppFlags. Totally eliminate any risk of the following happening: Also removed the old MPEGTS_DUPLICATE_NO and added GRAPH_NO as well as switched manual UNICODE to ENABLE_UNICODE which ZenLib controls and sorted the arguments. |
cjee21
force-pushed
the
android
branch
2 times, most recently
from
c16df3f to
8784fe0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that we only have one
libmediainfo.soin the APK and probably smaller too (I did not check). Also simplify the CMake file used for Android build and set thecmake_minimum_requiredto match MediaInfoLib. This also prevents the introduction of more.sofiles and makes it easier (only one new line of code) when we add Brotli in the future.