Skip to content

Windows GUIs: Icons for dark mode#1243

Open
cjee21 wants to merge 2 commits intoMediaArea:masterfrom
cjee21:appx
Open

Windows GUIs: Icons for dark mode#1243
cjee21 wants to merge 2 commits intoMediaArea:masterfrom
cjee21:appx

Conversation

@cjee21
Copy link
Collaborator

@cjee21 cjee21 commented Mar 11, 2026

  1. edit SVG to invert black and white parts
  2. generate PNG from SVG with GIMP
  3. generate assets with Visual Studio
  4. manually combine and rename light/dark mode assets
  5. edit manifest and regenerate pri as necessary

@cjee21
Copy link
Collaborator Author

cjee21 commented Mar 11, 2026

Only done for Qt GUI for now to test.

It works on Windows 11:

Screenshot 2026-03-11 223912

@cjee21 cjee21 force-pushed the appx branch 2 times, most recently from b1f3705 to 09a628c Compare March 11, 2026 16:30
@cjee21
Copy link
Collaborator Author

cjee21 commented Mar 11, 2026

Ok, let's see if this works. I have moved all images to resources folder. It will now copy images and generate the pri when building.

Need to test on Windows 10 with all possible tile sizes on both light and dark to ensure all is well. I cannot build the installer locally anymore and also no space for a Windows 10 VM. The Qt fully packaged MSIX should be tested on Windows 10 as well but that is difficult since there is no signed build from the build farm yet.

@cjee21
Copy link
Collaborator Author

cjee21 commented Mar 11, 2026

Oh wait, the assets got messed up when moving due to similar folder names just now.

@cjee21
Copy link
Collaborator Author

cjee21 commented Mar 11, 2026

Ok now.

@cjee21
Copy link
Collaborator Author

cjee21 commented Mar 11, 2026

Argh copy paste mistake. Should be really OK now.

@JeromeMartinez
Copy link
Member

Only done for Qt GUI for now to test.

I don't build the Qt package on Windows yet, could you share a build? And/or add the support of the BCB version? (I would understand if you prefer no to do it, but I try :) ).

@cjee21
Copy link
Collaborator Author

cjee21 commented Mar 24, 2026

I don't build the Qt package on Windows yet, could you share a build? And/or add the support of the BCB version? (I would understand if you prefer no to do it, but I try :) ).

That is old comment. Now this PR is for both Qt and BCB.

The Qt one I already tested on Windows 11. I can share build but the unsigned build cannot be installed on Windows 10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants