Skip to content

Conversation

@mtbayley
Copy link
Contributor

Description

Closes #5737

  • Update Icon classes to const string
  • Update to FontAwesome 6.6.0

How Has This Been Tested?

Tested using Icon page in BasicTestApp

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist:

  • The PR is submitted to the correct branch (master for dev, rel-1.x for maintenance).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2024

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
@mtbayley
@michael Bayley
Michael Bayley seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@mtbayley mtbayley marked this pull request as ready for review September 19, 2024 12:30
github-actions bot added a commit that referenced this pull request Sep 19, 2024
@mtbayley
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@mtbayley
Copy link
Contributor Author

recheck

@mtbayley mtbayley closed this Sep 19, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2024
@mtbayley mtbayley deleted the dev-const-icon-class branch September 19, 2024 14:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FontAwesomeIcons constants

1 participant