Show archive meetups in reverse chronological order #52
Conversation
Show Archive in reverse chronological order
|
@aolives Can you rerun the build with this change? |
…older archive pages.
|
@iansltx Does that look better? I'm still new to all this. |
|
Looks closer at least. I'll take a better look at this over the weekend. |
| @@ -61,7 +61,7 @@ protected function generateArchivePage(int $year, array $meetups): void | |||
| } | |||
|
|
|||
| $meetups = array_map(fn(MeetupEntry $meetupEntry) => $meetupEntry->instance, $meetups); | |||
| rsort($meetups); | |||
| usort($meetups, fn($a, $b) => $b->getDateTime() <=> $a->getDateTime()); | |||
There was a problem hiding this comment.
There's already a sort method on the (doubly-linked list) collection class:
That method is already called on the instance that is injected into this class on line 18. So if the collection is already sorted by the time it arrives at this line I'm not sure why rsort doesn't work. A cursory glance has left me more confused than when I started.
Once we get to the bottom of that it'd be nice to have a test around this so we can't break it in the next refactor
There was a problem hiding this comment.
There $meetups is just an array of MeetupEntry rather than the collection.
I think rsort doesn't know we want MeetupEntries sorted by date.
Also, for what it's worth, if I implement the sort on the collection it messes up the order of the RSS feed too which I really don't want to mess with.
|
No pressure, but I didn't know if there was anything I was supposed to do with this to move it forward. |
Seeing the latest meetup at the top rather than the earliest meetup in the year seemed like it might be a nice change.