Skip to content

Conversation

@chrisspruck
Copy link
Contributor

@chrisspruck chrisspruck commented Jul 9, 2025

I followed the instructions in the README to do this build and these source files look ok, but when I serve it via localhost, the various pieces of text like presenter, description, bio, etc. are intermingled (see screenshot). Some style seems crossed up too, though I didn't introduce any changes that would touch that - just did the text input per build instructions.

If Tim et al think this is OK, it's OK with me to merge to main.

Screen Shot 2025-07-08 at 5 55 47 PM

@chrisspruck chrisspruck requested a review from cookieguru July 9, 2025 04:29
@chrisspruck chrisspruck self-assigned this Jul 9, 2025
@cookieguru
Copy link
Contributor

I pulled your branch, built locally, and everything looks perfect

I say we fix the lint error and do a YOLO deploy

@cookieguru cookieguru merged commit f3ecde7 into main Jul 9, 2025
2 of 3 checks passed
@cookieguru cookieguru deleted the july2025 branch July 9, 2025 06:12
@cookieguru
Copy link
Contributor

The build check is failing for reasons I can't explain; going to merge this in anyways

@cookieguru
Copy link
Contributor

@chrisspruck the only theory I have about the wonkiness is that your browser cached a stylesheet for something else that was served from localhost:8000

@cookieguru
Copy link
Contributor

The built site looks great:

Screenshot of mergephp.com after changes from this PR were applied

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants