Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Central meta changes #57

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Central meta changes #57

wants to merge 8 commits into from

Conversation

james-bruten-mo
Copy link
Contributor

@james-bruten-mo james-bruten-mo commented Jan 21, 2025

Linked with LFRic_Apps:#544.

Changes required to the apply_macros script once metadata import paths work from a toplevel rose-meta directory. This PR will keep backwards compatibility with previous import commands.

This needs to be committed before LFRic_Apps:#544

@james-bruten-mo james-bruten-mo requested review from t00sa and removed request for t00sa January 21, 2025 14:01
Copy link

@yaswant yaswant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good, technically, barring couple of minor comments on portability...

@james-bruten-mo
Copy link
Contributor Author

Thanks Yash, have fixed the typos, but I think we want to stick with the : for the rose_meta_path part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants