Skip to content

Adds discussion FAQs #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 12, 2025
Merged

Adds discussion FAQs #94

merged 5 commits into from
Mar 12, 2025

Conversation

astroDimitrios
Copy link
Member

Fixes #5

@astroDimitrios astroDimitrios requested a review from a team March 12, 2025 16:28
@astroDimitrios astroDimitrios self-assigned this Mar 12, 2025
rcomer
rcomer reviewed Mar 12, 2025
View reviewed changes
Copy link
Member

@rcomer rcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a couple of typos

pwhybra
pwhybra reviewed Mar 12, 2025
View reviewed changes
pwhybra
pwhybra reviewed Mar 12, 2025
View reviewed changes
wxtim
wxtim reviewed Mar 12, 2025
View reviewed changes
wxtim
wxtim reviewed Mar 12, 2025
View reviewed changes
wxtim
wxtim approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@wxtim wxtim left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran through reading age checker and was happy with the result. There are a few trivial suggestions but should not block.

astroDimitrios and others added 3 commits March 12, 2025 16:58
@astroDimitrios @pwhybra
Emphasise origin and upstream
3929c51 
Co-authored-by: pwhybra <[email protected]>
@astroDimitrios @wxtim @rcomer
Spelling and word choice fixes
2cc5161 
Co-authored-by: Tim Pillinger <[email protected]>
Co-authored-by: Ruth Comer <[email protected]>
@astroDimitrios @wxtim
Apply reading age suggestions
ceffa64 
Co-authored-by: Tim Pillinger <[email protected]>
s-boardman
s-boardman reviewed Mar 12, 2025
View reviewed changes
astroDimitrios
astroDimitrios commented Mar 12, 2025
View reviewed changes
@astroDimitrios astroDimitrios merged commit b7dca18 into MetOffice:main Mar 12, 2025
1 check passed
@astroDimitrios astroDimitrios deleted the 5_discussion branch March 12, 2025 17:04
github-actions bot pushed a commit to astroDimitrios/git-working-practices that referenced this pull request Mar 12, 2025
@actions-user @pwhybra
@wxtim @rcomer
markdown source builds
e1cf5ee 
Auto-generated via `{sandpaper}`
Source  : b7dca18
Branch  : main
Author  : Dimitrios Theodorakis <[email protected]>
Time    : 2025-03-12 17:04:51 +0000
Message : MetOffice#94 Adds discussion FAQs

* Adds discussion FAQs

* Emphasise origin and upstream

Co-authored-by: pwhybra <[email protected]>

* Spelling and word choice fixes

Co-authored-by: Tim Pillinger <[email protected]>
Co-authored-by: Ruth Comer <[email protected]>

* Apply reading age suggestions

Co-authored-by: Tim Pillinger <[email protected]>

* Add a GitHub docs link for git fetch

---------

Co-authored-by: pwhybra <[email protected]>
Co-authored-by: Tim Pillinger <[email protected]>
Co-authored-by: Ruth Comer <[email protected]>
github-actions bot pushed a commit to astroDimitrios/git-working-practices that referenced this pull request Mar 12, 2025
@actions-user @pwhybra
@wxtim @rcomer
site deploy
c3950a6 
Auto-generated via `{sandpaper}`
Source  : e1cf5ee
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-03-12 17:06:00 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : b7dca18
Branch  : main
Author  : Dimitrios Theodorakis <[email protected]>
Time    : 2025-03-12 17:04:51 +0000
Message : MetOffice#94 Adds discussion FAQs

* Adds discussion FAQs

* Emphasise origin and upstream

Co-authored-by: pwhybra <[email protected]>

* Spelling and word choice fixes

Co-authored-by: Tim Pillinger <[email protected]>
Co-authored-by: Ruth Comer <[email protected]>

* Apply reading age suggestions

Co-authored-by: Tim Pillinger <[email protected]>

* Add a GitHub docs link for git fetch

---------

Co-authored-by: pwhybra <[email protected]>
Co-authored-by: Tim Pillinger <[email protected]>
Co-authored-by: Ruth Comer <[email protected]>
MetRonnie
MetRonnie reviewed Mar 12, 2025
View reviewed changes
learners/discuss.md
Comment on lines +24 to +29
5. Can you have chains of forks? Or a colleagues fork as a remote?
Yes to both! Although the latter would be an unusual working practice,
we'd recommend seeking advice before adding a colleague's fork
as another remote on your local repository.
Chains of forks are common. If a GitHub user has read access to your
repository they can create a fork.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry am late to the party, but why is having a colleague's fork as a remote considered unusual? If anything I'd say this is more likely to happen than chain of forks, which only really happens in open-source-land and is unlikely to be useful for MetOffice organisation repos?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-boardman s-boardman s-boardman left review comments

@rcomer rcomer rcomer left review comments

@pwhybra pwhybra pwhybra left review comments

@MetRonnie MetRonnie MetRonnie left review comments

@wxtim wxtim wxtim approved these changes

Assignees

@astroDimitrios astroDimitrios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add content to the discussion section?
6 participants
@astroDimitrios @s-boardman @rcomer @pwhybra @wxtim @MetRonnie