Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vernier #8

Merged
merged 10 commits into from
Feb 4, 2025
Merged

Vernier #8

merged 10 commits into from
Feb 4, 2025

Conversation

hiker
Copy link
Collaborator

@hiker hiker commented Jan 8, 2025

Vernier was officially merged into PSyclone. The vernier wrapper file included here is identical with the psyclone version now. Ready for review.

@hiker hiker requested a review from jasonjunweilyu February 3, 2025 03:01
Copy link
Collaborator

@jasonjunweilyu jasonjunweilyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hiker , I have finished reviewing with just a typo suggestion and a small comment. Then this PR should be ready to go into main when the linker_wrapper issue is fixed.

infrastructure/build/fab/lfric_base.py Outdated Show resolved Hide resolved
@hiker hiker requested a review from jasonjunweilyu February 4, 2025 23:16
Copy link
Collaborator

@jasonjunweilyu jasonjunweilyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hiker . I think now this is ready to be merged into main.

@jasonjunweilyu jasonjunweilyu merged commit daf1547 into main Feb 4, 2025
3 checks passed
@jasonjunweilyu jasonjunweilyu deleted the vernier branch February 4, 2025 23:25
@hiker hiker restored the vernier branch February 5, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants