Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add namelist and ctest files/yamls for SEVIRI UKV #214

Merged
merged 16 commits into from
Jul 16, 2024
Merged

Add namelist and ctest files/yamls for SEVIRI UKV #214

merged 16 commits into from
Jul 16, 2024

Conversation

PJLevensMO
Copy link
Contributor

Addresses #213 by adding namelist, ctests for SEVIRIClr and SEVIRIASR in the UKV

@PJLevensMO PJLevensMO self-assigned this Jul 4, 2024
ctgh
ctgh reviewed Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@ctgh ctgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this - just two comments.

test/testinput/varobswriter_ukvnamelist_seviriasr.yaml Show resolved Hide resolved
test/testinput/varobswriter_ukvnamelist_seviriasr.yaml Show resolved Hide resolved
mikecooke77
mikecooke77 approved these changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@mikecooke77 mikecooke77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible to me

ctgh
ctgh approved these changes Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@ctgh ctgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making all of the changes. If this is ready to merge, please apply the "ready to merge" label and we can add it.

@ctgh ctgh merged commit 3c6673d into develop Jul 16, 2024
6 checks passed
@ctgh ctgh deleted the feature/seviri_ukv branch July 16, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctgh ctgh ctgh approved these changes

@mikecooke77 mikecooke77 mikecooke77 approved these changes

@smnewman smnewman Awaiting requested review from smnewman

@stemiglio stemiglio Awaiting requested review from stemiglio

@orlewis orlewis Awaiting requested review from orlewis

Assignees

@PJLevensMO PJLevensMO

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PJLevensMO @ctgh @mikecooke77 @matthewrmshin