-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model Variable Naming Sprint: Part 4 #227
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJDavies2
approved these changes
Oct 8, 2024
ctgh
reviewed
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this. Did you also want to change exner_levels
?
ctgh
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me!
matthewrmshin
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of variable name code sprint, this PR renames variables from group 4:
potential_temperature
->air_potential_temperature
exner_levels
->dimensionless_exner_function_levels
I didn't find any instances of:
exner
->dimensionless_exner_function
exner_levels_minus_one
->dimensionless_exner_function_levels_minus_one
Issue(s) addressed
A separate one was not created.
Dependencies
build-group=https://github.com/JCSDA-internal/saber/pull/955
build-group=https://github.com/JCSDA-internal/ufo/pull/3485
build-group=JCSDA-internal/ufo-data#453
build-group=https://github.com/JCSDA-internal/vader/pull/276
build-group=https://github.com/JCSDA-internal/lfric-jedi/pull/908
build-group=https://github.com/JCSDA-internal/ops-um-jedi/pull/235
build-group=https://github.com/MetOffice/jjtests/pull/48
Impact
No impacts expected beyond the list in dependencies above
Checklist