Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model Variable Naming Sprint: Part 4 #227

Merged
merged 6 commits into from
Oct 9, 2024

Conversation

ss421
Copy link
Contributor

@ss421 ss421 commented Oct 8, 2024

Description

As part of variable name code sprint, this PR renames variables from group 4:

potential_temperature -> air_potential_temperature
exner_levels -> dimensionless_exner_function_levels

I didn't find any instances of:
exner -> dimensionless_exner_function
exner_levels_minus_one -> dimensionless_exner_function_levels_minus_one

Issue(s) addressed

A separate one was not created.

Dependencies

build-group=https://github.com/JCSDA-internal/saber/pull/955
build-group=https://github.com/JCSDA-internal/ufo/pull/3485
build-group=JCSDA-internal/ufo-data#453
build-group=https://github.com/JCSDA-internal/vader/pull/276
build-group=https://github.com/JCSDA-internal/lfric-jedi/pull/908
build-group=https://github.com/JCSDA-internal/ops-um-jedi/pull/235
build-group=https://github.com/MetOffice/jjtests/pull/48

Impact

No impacts expected beyond the list in dependencies above

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

@ss421 ss421 self-assigned this Oct 8, 2024
@ss421 ss421 marked this pull request as ready for review October 8, 2024 12:55
Copy link
Collaborator

@ctgh ctgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. Did you also want to change exner_levels?

@ss421
Copy link
Contributor Author

ss421 commented Oct 9, 2024

Thanks for adding this. Did you also want to change exner_levels?

@ctgh Thanks! I seem to have totally missed that :-(. I've updated it now and comited at: f999db6

Copy link
Collaborator

@ctgh ctgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me!

@mikecooke77 mikecooke77 merged commit 7262cd0 into develop Oct 9, 2024
5 checks passed
@mikecooke77 mikecooke77 deleted the feature/variable_names_part4 branch October 9, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants