Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-rank domain decomposition test #13

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

jeff-cole
Copy link
Collaborator

This test case extends read_domain_resample to use multiple processors and domain decomposition to resample the data.

File shared_testing.py was copied from mo-marqh/tcd-XIOS-demonstration branch mpirankborder

@jeff-cole jeff-cole requested a review from mo-marqh April 17, 2024 15:46
@mo-marqh
Copy link
Member

Hi Jeff

this is failing the CI testing, it's trying, but it's falling over trying to allocate threads on the Ubuntu Action runner.
It's only a little VM

there's a flag to help with this:
https://github.com/MetOffice/tcd-XIOS-demonstration/pull/13/files#diff-42afd176f6b281857ba3050c03b8f51fe50437203375902a27fb88861ad6c40aR38

but it needs conditionally activating, for openmpi cases only

you'll need to add an environment variable into .github/workflows/buildTest.yml
that activates this trigger, but only on github, as we don't want nor need it on other platforms, with different MPI implementations

https://github.com/MetOffice/tcd-XIOS-demonstration/pull/12/files#diff-c66e53f9783d6581f7b6a720487764481cd7a10fde3d4d3a235f3390b6749cce

that should at least get this test rerun get further

many thanks
mark

@jeff-cole
Copy link
Collaborator Author

Thanks, that worked.

Copy link
Member

@mo-marqh mo-marqh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many thanks @jeff-cole

@mo-marqh mo-marqh merged commit 8db37f6 into MetOffice:main Apr 18, 2024
4 checks passed
This was referenced Apr 23, 2024
@jeff-cole jeff-cole deleted the read_domain_decomp_resample branch April 30, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants