Add a simple parallel write example #21
Conversation
svadams
force-pushed
the
paralle1_write_example
branch
from
913500e to
e02c61e
Compare
platform compatability
There was a problem hiding this comment.
hi @svadams
this looks good,
i'd like to see this running with 2 clients and 2 servers for parallelism demonstration.
other than that there a a few v minor changes suggested in this review, which you can adopt or push back on as you see fit.
many thanks
mark
| # run the compiled Fortran XIOS programme | ||
| with open('{}/xios.xml'.format(self.test_dir)) as cxml: | ||
| print(cxml.read(), flush=True) | ||
| self.run_mpi_xios() |
There was a problem hiding this comment.
this test is configured for parallel writing, but there is only 1 client and 1 server.
i think that this still runs fine if both nclients and nservers is set to 2, so dual parallel
please may you update this line to
self.run_mpi_xios(nclients=2, nservers=2)
|
|
||
| # Check the expected output file exists | ||
| runfile_1 = '{}/{}'.format(self.test_dir, outputfile_1) | ||
| assert(os.path.exists(runfile_1)) |
There was a problem hiding this comment.
prefer self.assertTrue (to benefit from python's UnitTest assertion handling
| file_1_data = rootgrp['global_field_1'] | ||
|
|
||
| # Check file has 10 times | ||
| assert(file_1_data.shape[0] == 10) |
There was a problem hiding this comment.
prefer self.assertTrue (to benefit from python's UnitTest assertion handling
| if not np.allclose(result, expected, rtol=self.rtol): | ||
| # print message for fail case, | ||
| # as expected failures do not report msg. | ||
| print(msg) |
There was a problem hiding this comment.
i think that lines #48-#51 are not used here, as there are no expected failures being handled
i suggest removing
Parallel write example with synthetic data showing output at a user-defined interval. Some basic unit tests have been added to check the file is created and has the correct number of data points in it