Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read4D #43

Merged
merged 16 commits into from
Jan 14, 2025
Merged

Read4D #43

merged 16 commits into from
Jan 14, 2025

Conversation

mo-marqh
Copy link
Member

@mo-marqh mo-marqh commented Jan 7, 2025

exploring multi-dimensional read behaviour

this new example adds a 4D structured input file and simply reads data from that file into memory

This is designed to be extensible, enabling much larger files to be read, across multiple client and server ranks, and performance analyses undertaken

@mo-marqh
Copy link
Member Author

mo-marqh commented Jan 7, 2025

n.b. there are lots of commits here, as I made a bit of a meal of the implementation details
So, please squash&merge

@mo-marqh mo-marqh requested a review from EdHone January 7, 2025 14:30
Copy link
Collaborator

@EdHone EdHone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the comment @mo-marqh - I've managed to get a current HoT XIOS2 build and run your test successfully with that this morning, so I'm happy that this PR passes my code review

@EdHone EdHone merged commit 038f432 into MetOffice:main Jan 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants