-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add YRC Token (Polygon) to MetaMask Registry #1641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| "logo": "0x05D2310F57e13F8f51198197508BD3ed71A2597b.png" | ||
| }, | ||
| { | ||
| "0x49d716DFe60b37379010A75329ae09428f17118d": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Invalid JSON structure breaks token registry parsing
The new YRC token entry creates invalid JSON syntax. After the closing }, on line 8, there's a standalone { on line 9 that has no key in the parent object. In valid JSON, every value in an object must have an associated key. This causes the entire contract-map.json file to fail parsing, which will break MetaMask's token detection functionality for all tokens.
| { | ||
| "0x49d716DFe60b37379010A75329ae09428f17118d": { | ||
| "name": "PoolTogether Dai", | ||
| "logo": "pldai.svg", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Token symbol mismatch after incorrect merge
The token entry for address 0x49d716DFe60b37379010A75329ae09428f17118d now has inconsistent metadata - it's named "PoolTogether Dai" but has symbol: "CYBER". This appears to be residual data from the deleted "Cyber" token entry. The symbol should likely be plDAI or similar to match the token name and logo (pldai.svg).
| "decimals": 3, | ||
| "erc20": true, | ||
| "logo": "0x05D2310F57e13F8f51198197508BD3ed71A2597b.png" | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Cyber token unintentionally removed from registry
The Cyber token entry at address 0x14778860E937f509e651192a90589dE711Fb88a9 with symbol CYBER has been completely removed from the registry. The PR description only mentions adding the YRC token, not removing Cyber. This appears to be an unintentional deletion resulting from the malformed edit, causing MetaMask to no longer auto-detect the Cyber token for users.
Added YRC token metadata and logo for automatic detection in MetaMask wallets.
Note
Adds
Yourcoin (YRC)tocontract-map.jsonand updates entries near the top, including replacing theCybermapping withPoolTogether Dai.contract-map.json):Yourcoin (YRC)at0x05D2310F57e13F8f51198197508BD3ed71A2597bwithdecimals: 3,erc20: true, and logo0x05D2310F57e13F8f51198197508BD3ed71A2597b.png.Cyberat0x14778860E937f509e651192a90589dE711Fb88a9; addPoolTogether Daiat0x49d716DFe60b37379010A75329ae09428f17118dwitherc20: true.Written by Cursor Bugbot for commit 7e9f860. This will update automatically on new commits. Configure here.