Skip to content

Commit

Permalink
fix: fix peer deps for `@metamask/{accounts,multichain-network}-contr…
Browse files Browse the repository at this point in the history
…oller` (#5327)

## Explanation

The 2 controllers depend on each other, however we cannot really express
this with peer deps.

So for now, we only declare this "relation" on the new controller
`mutltichain-network-controller`.

Also downgrading some peer dep to use the major version.

## References

N/A

## Changelog

N/A

## Checklist

- [ ] I've updated the test suite for new or updated code as appropriate
- [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [ ] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
- [ ] I've prepared draft pull requests for clients and consumer
packages to resolve any breaking changes

---------

Co-authored-by: Cal-L <[email protected]>
  • Loading branch information
ccharly and Cal-L authored Feb 13, 2025
1 parent fe244b1 commit d2d1800
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 7 deletions.
6 changes: 3 additions & 3 deletions packages/accounts-controller/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@
"@metamask/eth-snap-keyring": "^10.0.0",
"@metamask/keyring-api": "^17.0.0",
"@metamask/keyring-internal-api": "^4.0.1",
"@metamask/network-controller": "^22.2.1",
"@metamask/snaps-sdk": "^6.17.1",
"@metamask/snaps-utils": "^8.10.0",
"@metamask/utils": "^11.1.0",
Expand All @@ -63,7 +64,6 @@
"devDependencies": {
"@metamask/auto-changelog": "^3.4.4",
"@metamask/keyring-controller": "^19.1.0",
"@metamask/network-controller": "^22.2.1",
"@metamask/providers": "^18.1.1",
"@metamask/snaps-controllers": "^9.19.0",
"@types/jest": "^27.4.1",
Expand All @@ -76,8 +76,8 @@
"webextension-polyfill": "^0.12.0"
},
"peerDependencies": {
"@metamask/keyring-controller": "^19.1.0",
"@metamask/network-controller": "^22.2.1",
"@metamask/keyring-controller": "^19.0.0",
"@metamask/network-controller": "^22.0.0",
"@metamask/providers": "^18.1.0",
"@metamask/snaps-controllers": "^9.19.0",
"webextension-polyfill": "^0.10.0 || ^0.11.0 || ^0.12.0"
Expand Down
3 changes: 2 additions & 1 deletion packages/multichain-network-controller/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@
"typescript": "~5.2.2"
},
"peerDependencies": {
"@metamask/network-controller": "^22.2.1"
"@metamask/accounts-controller": "^23.0.0",
"@metamask/network-controller": "^22.0.0"
},
"engines": {
"node": "^18.18 || >=20"
Expand Down
7 changes: 4 additions & 3 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2370,8 +2370,8 @@ __metadata:
uuid: "npm:^8.3.2"
webextension-polyfill: "npm:^0.12.0"
peerDependencies:
"@metamask/keyring-controller": ^19.1.0
"@metamask/network-controller": ^22.2.1
"@metamask/keyring-controller": ^19.0.0
"@metamask/network-controller": ^22.0.0
"@metamask/providers": ^18.1.0
"@metamask/snaps-controllers": ^9.19.0
webextension-polyfill: ^0.10.0 || ^0.11.0 || ^0.12.0
Expand Down Expand Up @@ -3475,7 +3475,8 @@ __metadata:
typedoc-plugin-missing-exports: "npm:^2.0.0"
typescript: "npm:~5.2.2"
peerDependencies:
"@metamask/network-controller": ^22.2.1
"@metamask/accounts-controller": ^23.0.0
"@metamask/network-controller": ^22.0.0
languageName: unknown
linkType: soft

Expand Down

0 comments on commit d2d1800

Please sign in to comment.