chore: update logoUrl to be handled as optional

MetaMask · Jan 27, 2025 · dd78982 · dd78982
1 parent caa9529
commit dd78982
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/...search-discovery-controller/src/token-search-api-service/token-search-api-service.test.ts b/...search-discovery-controller/src/token-search-api-service/token-search-api-service.test.ts
@@ -14,7 +14,7 @@ describe('TokenSearchApiService', () => {
         tokenAddress: '0x1',
         usdPrice: 100,
         usdPricePercentChange: { oneDay: 10 },
-        logoUrl: 'https://example.com/api/v1/tokenIcons/1/0x1.png',
+        logoUrl: 'https://static.cx.metamask.io/api/v1/tokenIcons/1/0x1.png',
       },
       {
         name: 'Token2',
@@ -23,7 +23,6 @@ describe('TokenSearchApiService', () => {
         tokenAddress: '0x2',
         usdPrice: 200,
         usdPricePercentChange: { oneDay: 20 },
-        logoUrl: 'https://example.com/api/v1/tokenIcons/1/0x2.png',
       },
     ],
     onlyChain: [
@@ -34,7 +33,7 @@ describe('TokenSearchApiService', () => {
         tokenAddress: '0x3',
         usdPrice: 300,
         usdPricePercentChange: { oneDay: 30 },
-        logoUrl: 'https://example.com/api/v1/tokenIcons/1/0x3.png',
+        logoUrl: 'https://static.cx.metamask.io/api/v1/tokenIcons/1/0x3.png',
       },
     ],
     onlyName: [
@@ -45,7 +44,6 @@ describe('TokenSearchApiService', () => {
         tokenAddress: '0x4',
         usdPrice: 400,
         usdPricePercentChange: { oneDay: 40 },
-        logoUrl: 'https://example.com/api/v1/tokenIcons/1/0x4.png',
       },
     ],
   };

diff --git a/packages/token-search-discovery-controller/src/token-search-discovery-controller.test.ts b/packages/token-search-discovery-controller/src/token-search-discovery-controller.test.ts
@@ -35,7 +35,7 @@ describe('TokenSearchDiscoveryController', () => {
       usdPricePercentChange: {
         oneDay: 10,
       },
-      logoUrl: 'https://example.com/api/v1/tokenIcons/1/0x123.png',
+      // no logoUrl to test optional case
     },
   ];
 

diff --git a/packages/token-search-discovery-controller/src/types.ts b/packages/token-search-discovery-controller/src/types.ts
@@ -13,5 +13,5 @@ export type TokenSearchResponseItem = {
   usdPricePercentChange: {
     oneDay: number;
   };
-  logoUrl: string;
+  logoUrl?: string;
 };