Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typos in documentation files #5114

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

fix: typos in documentation files #5114

wants to merge 8 commits into from

Conversation

vtjl10
Copy link

@vtjl10 vtjl10 commented Jan 8, 2025

This pull request contains changes to improve clarity, correctness and structure.

Description correction:
Corrected exection to execution
Corrected hexidecimal to hexadecimal x2
Corrected emtpy to empty

Please review the changes and let me know if any additional changes are needed.

@vtjl10 vtjl10 requested review from a team as code owners January 8, 2025 11:32
Gudahtt
Gudahtt previously approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@mcmire
Copy link
Contributor

mcmire commented Jan 8, 2025

@vtjl10 It looks like this causes some tests to fail in the tests for NameController, would you be willing to fix those cases too?

@Gudahtt Gudahtt dismissed their stale review January 8, 2025 20:50

Test failures

@vtjl10 vtjl10 requested a review from Gudahtt January 22, 2025 22:35
@mcmire mcmire enabled auto-merge (squash) January 31, 2025 21:00
@mcmire mcmire disabled auto-merge January 31, 2025 21:00
@mcmire
Copy link
Contributor

mcmire commented Jan 31, 2025

@vtjl10 I fixed the test on this PR. We are just awaiting approval from @MetaMask/confirmations .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptodev-2s cryptodev-2s cryptodev-2s approved these changes

@Gudahtt Gudahtt Awaiting requested review from Gudahtt

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vtjl10 @mcmire @Gudahtt @cryptodev-2s