Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 302.0.0 #5346

Merged
merged 25 commits into from
Feb 18, 2025
Merged

Release 302.0.0 #5346

merged 25 commits into from
Feb 18, 2025

Conversation

smilingkylan
Copy link
Contributor

Explanation

Bump remote-feature-flag-controller and core package

DDDDDanica
DDDDDanica previously approved these changes Feb 14, 2025
mcmire
mcmire previously requested changes Feb 14, 2025
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we are introducing a new change to the src/ or tests/ directory of a package and releasing that package in the same PR. I realize we might be doing this to save time, but we don't typically do this as it makes things confusing when looking back at the history. We tend to keep any changes to release PRs just to satisfy the release itself. Can we cut a new release in a separate PR?

(Edit: Oh, I see we have #5341. Perhaps we should merge that first?)

@smilingkylan
Copy link
Contributor Author

smilingkylan commented Feb 14, 2025

#5341

Are you able to merge that PR? For whatever reason it doesn't seem like it will let me

image

@mcmire
Copy link
Contributor

mcmire commented Feb 17, 2025

@smilingkylan Can we retitle this PR "Release 302.0.0"? We have a workflow in place which will automatically publish the new version when this PR is merged, but that won't happen if this PR is not named correctly.

@smilingkylan smilingkylan requested review from a team as code owners February 17, 2025 19:48
@smilingkylan smilingkylan changed the title chore: bump package to v302.0.0 and remote-feature-flag-controller to 1.5.0 Release 302.0.0 Feb 17, 2025
@cryptodev-2s
Copy link
Contributor

cryptodev-2s commented Feb 17, 2025

@smilingkylan please update this package in transaction-controller as it's a peer dependency from 1.4.0 to 1.5.0 to fix the lint issue. Also, if you can add a changelog entry for this update under the “Unreleased” section as Changed in the transaction-controller changelog.

@smilingkylan smilingkylan requested a review from a team as a code owner February 17, 2025 23:20
Copy link

socket-security bot commented Feb 17, 2025

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

@smilingkylan
Copy link
Contributor Author

@smilingkylan please update this package in transaction-controller as it's a peer dependency from 1.4.0 to 1.5.0 to fix the lint issue. Also, if you can add a changelog entry for this update under the “Unreleased” section as Changed in the transaction-controller changelog.

You able to take a look now @cryptodev-2s @mcmire . Let me know if I need any more changes.

@cryptodev-2s
Copy link
Contributor

@smilingkylan The lock file needs to be updated. Could you please run yarn to update it?

Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cryptodev-2s cryptodev-2s requested a review from mcmire February 18, 2025 01:48
@smilingkylan smilingkylan enabled auto-merge (squash) February 18, 2025 01:55
@smilingkylan smilingkylan dismissed mcmire’s stale review February 18, 2025 01:57

Other PR already merged in

@smilingkylan smilingkylan merged commit f2d4645 into main Feb 18, 2025
134 checks passed
@smilingkylan smilingkylan deleted the release/302.0.0 branch February 18, 2025 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants