-
-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 302.0.0 #5346
Release 302.0.0 #5346
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we are introducing a new change to the src/
or tests/
directory of a package and releasing that package in the same PR. I realize we might be doing this to save time, but we don't typically do this as it makes things confusing when looking back at the history. We tend to keep any changes to release PRs just to satisfy the release itself. Can we cut a new release in a separate PR?
(Edit: Oh, I see we have #5341. Perhaps we should merge that first?)
@smilingkylan Can we retitle this PR "Release 302.0.0"? We have a workflow in place which will automatically publish the new version when this PR is merged, but that won't happen if this PR is not named correctly. |
@smilingkylan please update this package in transaction-controller as it's a peer dependency from 1.4.0 to 1.5.0 to fix the lint issue. Also, if you can add a changelog entry for this update under the “Unreleased” section as Changed in the transaction-controller changelog. |
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/@metamask/[email protected] |
Co-authored-by: Mark Stacey <[email protected]>
You able to take a look now @cryptodev-2s @mcmire . Let me know if I need any more changes. |
Co-authored-by: cryptodev-2s <[email protected]>
Co-authored-by: cryptodev-2s <[email protected]>
@smilingkylan The lock file needs to be updated. Could you please run yarn to update it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Explanation
Bump remote-feature-flag-controller and core package