Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Add CODEOWNER constraints #5352

Merged
merged 2 commits into from
Feb 18, 2025
Merged

ci: Add CODEOWNER constraints #5352

merged 2 commits into from
Feb 18, 2025

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Feb 17, 2025

Explanation

Add Yarn constraints to ensure each package has a designated owner, and that any non-wallet-frameowrk packages have the wallet framework team set as co-owners of release related files.

References

N/A

Changelog

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@Gudahtt Gudahtt force-pushed the add-codeowner-constraints branch from fc2cca3 to 67d848e Compare February 17, 2025 19:17
@Gudahtt

This comment was marked as resolved.

Sign in to view
mikesposito
mikesposito reviewed Feb 17, 2025
View reviewed changes
yarn.config.cjs Outdated Show resolved Hide resolved
Base automatically changed from add-missing-codeowner-rules to main February 17, 2025 20:14
@Gudahtt Gudahtt force-pushed the add-codeowner-constraints branch from 67d848e to 6d22c09 Compare February 17, 2025 20:15
mikesposito
mikesposito approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@mikesposito mikesposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt marked this pull request as ready for review February 18, 2025 16:04
@Gudahtt
ci: Add CODEOWNER constraints
cc5fc45 
Add Yarn constraints to ensure each package has a designated owner, and
that any non-wallet-frameowrk packages have the wallet framework team
set as co-owners of release related files.
@Gudahtt
Adjust matcher to ensure there is a rule for the entire package
2d6a162
@Gudahtt Gudahtt force-pushed the add-codeowner-constraints branch from 06d5462 to 2d6a162 Compare February 18, 2025 16:04
@Gudahtt Gudahtt enabled auto-merge (squash) February 18, 2025 16:16
@Gudahtt Gudahtt merged commit 48b1b68 into main Feb 18, 2025
133 checks passed
@Gudahtt Gudahtt deleted the add-codeowner-constraints branch February 18, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikesposito mikesposito mikesposito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gudahtt @mikesposito