feat: optimise push controller API calls #5358
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Our new backend change allows us to ditch the "Pull then Push" approach for push notification registration links.
So we can remove 1 query in our enable/disable/update notifications flow.
There are still many more API calls we make (notifications flow talks back and forth between 4/5 services), but at least this is a first step.
References
Changelog
@metamask/notification-services-controller
getPushNotificationLinks
API call as this is not needed due to backend optimizations.Checklist