Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimise push controller API calls #5358

Merged
merged 4 commits into from
Feb 18, 2025

Conversation

Prithpal-Sooriya
Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya commented Feb 18, 2025

Explanation

Our new backend change allows us to ditch the "Pull then Push" approach for push notification registration links.
So we can remove 1 query in our enable/disable/update notifications flow.

There are still many more API calls we make (notifications flow talks back and forth between 4/5 services), but at least this is a first step.

References

Changelog

@metamask/notification-services-controller

  • REMOVED: the getPushNotificationLinks API call as this is not needed due to backend optimizations.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

this is because we've made an optimization in our backend that allows us to not make a "pull then push" approach
@Prithpal-Sooriya Prithpal-Sooriya requested a review from a team as a code owner February 18, 2025 15:48
@Prithpal-Sooriya Prithpal-Sooriya enabled auto-merge (squash) February 18, 2025 17:58
@Prithpal-Sooriya Prithpal-Sooriya merged commit 620b633 into main Feb 18, 2025
133 checks passed
@Prithpal-Sooriya Prithpal-Sooriya deleted the remove-get-push-links-call branch February 18, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants