Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add mobile feature flags and fix tests #5359

Open
wants to merge 51 commits into
base: main
Choose a base branch
from
Open

feat: add mobile feature flags and fix tests #5359

wants to merge 51 commits into from

Conversation

infiniteflower
Copy link
Contributor

@infiniteflower infiniteflower commented Feb 18, 2025 •
edited
Loading

Explanation

This PR adds mobileConfig to the feature flags that BridgeController fetches to support the native Bridge experience on Mobile.

References

Changelog

@metamask/bridge-controller

  • ADDED: mobileConfig field added to bridgeFeatureFlags

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@infiniteflower infiniteflower marked this pull request as ready for review February 18, 2025 21:42
@infiniteflower infiniteflower requested a review from a team as a code owner February 18, 2025 21:42
infiniteflower and others added 28 commits February 18, 2025 17:09
@infiniteflower
chore: update yarn lock
8343c85
@infiniteflower
chore: setup skeleton for bridge status controller
624bc83
@infiniteflower
chore: update readme
1d0daae
@infiniteflower
chore: change version to 0.0.0 since it's not published
dc655d0
@infiniteflower
chore: update yarn lock
9582253
@infiniteflower
chore: add changelog
524192b
@infiniteflower
chore: initial commit of code
aba0200
@infiniteflower
chore: update packages
c69bcdc
@infiniteflower
chore: get all imports fixed
d2ce2e6
@infiniteflower
fix: broken tests
d5a1256
@infiniteflower
chore: remove mocks file to push test coverage up
4b95d16
@infiniteflower
feat: add fetchBridgeTxStatus test suite and export FeeType
00fd19c
@infiniteflower
test: add getStatusRequestDto tests and refactor utils test suite
c3556e2
@infiniteflower
test: add test for polling with no source transaction hash
e3d1a35
@infiniteflower
test: enhance startPollingForBridgeTxStatus test cases for not pollin…
8ebffe5 
…g when no srcTxHash
@infiniteflower
test: adjust coverage thresholds for bridge status controller
5ba5372
@infiniteflower
test: update coverage thresholds for bridge status controller
a038f08
@infiniteflower
test: add test cases for bridge transaction complete and failed events
1d5c5b7
@infiniteflower
test: add test case for updating srcTxHash during polling
cbde55a
@infiniteflower
refactor: simplify bridge status state updates
454e222
@infiniteflower
chore: increase coverage thresholds for bridge status controller
9a35a20
@infiniteflower
refactor: remove unused bridgeStatusState variable
45c0e21
@infiniteflower
chore: commit snapshots
0551f69
@infiniteflower
chore: fix lint error
b85ed67
@infiniteflower
chore: update CODEOWNERS
e2b6bf4
@infiniteflower @mcmire
Update packages/bridge-status-controller/package.json
bc586c0 
Co-authored-by: Elliot Winkler <[email protected]>
@infiniteflower
fix: move devDeps to deps for transaction controller
490595b
@infiniteflower
Revert "fix: move devDeps to deps for transaction controller"
6c8d118 
This reverts commit 810a141.
@infiniteflower infiniteflower force-pushed the feat/bridge-status-controller branch from b687a31 to 7cf0f59 Compare February 18, 2025 22:09
@infiniteflower infiniteflower requested a review from a team as a code owner February 18, 2025 22:09
infiniteflower and others added 14 commits February 18, 2025 19:18
@infiniteflower
chore: remove unused dep
df821b2
@infiniteflower
chore: remove unneeded @metamask/json-rpc-engine dependency
45fb6c8
@infiniteflower @mcmire
Update packages/bridge-status-controller/tsconfig.build.json
fbe37fe 
Co-authored-by: Elliot Winkler <[email protected]>
@infiniteflower @mcmire
Update packages/bridge-status-controller/tsconfig.json
f407152 
Co-authored-by: Elliot Winkler <[email protected]>
@infiniteflower
chore: remove unneeded @metamask/metamask-eth-abis dependency
3e761e4
@infiniteflower
Merge branch 'feat/bridge-status-controller' of github.com:MetaMask/c…
4790868 
…ore into feat/bridge-status-controller
@infiniteflower
chore: move transaction controller devDeps
1817aab
@infiniteflower
chore: update dependency graph
0b09fa9
@infiniteflower
chore: move transaction controller to devDeps for bridge controller
d35a619
@infiniteflower
chore: add bridge-controller as a direct dependency of bridge-status-…
c440941 
…controller
@infiniteflower
chore: add bridge-controller as a peer dependency for bridge-status-c…
4053595 
…ontroller
@infiniteflower
refactor: extract BridgeStatusControllerGetStateAction type
8c7aec4
@infiniteflower
feat: add resetState action to BridgeStatusController and export all …
33dab2e 
…actions and events
@infiniteflower
feat: add mobile feature flags and fix tests
ca28d2f
@infiniteflower infiniteflower force-pushed the feat/bridge-controller-mobile-config branch from 3a36309 to ca28d2f Compare February 19, 2025 04:06
Base automatically changed from feat/bridge-status-controller to main February 20, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@infiniteflower