ci: run build and test on newer node version, lint only on 12 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legobeat
commented
Nov 23, 2023
•
legobeat
commented
- ci: run build and test on newer node version, lint only on 12
- ci: pin to npm v6 for lockfile consistency
legobeat
requested review from
naugtur,
kumavis,
leotm,
Mrtenz,
NicholasEllul and
a team
NicholasEllul
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Noting: See MetaMask/ethjs-util#19 for context on why certain changes were made the way they were.
Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.