Document Snaps bundle analyzer option #1955
Merged
+31
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Mrtenz
requested changes
Apr 1, 2025
Co-authored-by: Maarten Zuidhoorn <[email protected]>
Mrtenz
previously approved these changes
Apr 1, 2025
bgravenorst
reviewed
Apr 1, 2025
bgravenorst
previously approved these changes
Apr 2, 2025
snaps/reference/cli/subcommands.md
Outdated
| Enables analyzing the Snap [bundle](../../learn/about-snaps/files.md#bundle-file). | ||
| This uses [`webpack-bundle-analyzer`](https://github.com/webpack-contrib/webpack-bundle-analyzer) under the hood, | ||
| which creates an interactive visualization of the contents of your bundle. | ||
| The visualization is located at the port displayed in the command line output. |
There was a problem hiding this comment.
Does this mean something like http://localhost:<port>>
There was a problem hiding this comment.
Yes - maybe "URL" is more clear?
bgravenorst
pushed a commit
that referenced
this pull request
Apr 17, 2025
* Document Snaps bundle analyzer option * Apply suggestions from code review Co-authored-by: Maarten Zuidhoorn <[email protected]> * edits * add more context * clarify analyzer url --------- Co-authored-by: Maarten Zuidhoorn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
yarn mm-snap build --analyze.Issue(s) fixed
Fixes #1875
Preview
https://metamask-docs-mnog1hnf3-consensys-ddffed67.vercel.app/snaps/reference/cli/subcommands/#analyze
Checklist
Complete this checklist before merging your PR: