-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(snaps): Add support for custom network per Snap #26389
base: main
Are you sure you want to change the base?
Conversation
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is a deprecated package?The maintainer of the package marked it as deprecated. This could indicate that a single version should not be used, or that the package is no longer maintained and any new vulnerabilities will not be fixed. Research the state of the package and determine if there are non-deprecated versions that can be used, or if it should be replaced with a new, supported solution. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
38edd7a
to
7f2494b
Compare
|
app/scripts/lib/rpc-method-middleware/handlers/ethereum-chain-utils.js
Outdated
Show resolved
Hide resolved
This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions. |
This PR was closed because there has been no follow up activity in the last 14 days. Thank you for your contributions. |
6453f80
to
cf763b1
Compare
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
@adonesky1 or @jiexi should review this PR too |
0110271
to
b74b5a8
Compare
Builds ready [b74b5a8]
Page Load Metrics (1927 ± 202 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
app/scripts/lib/rpc-method-middleware/handlers/ethereum-chain-utils.js
Outdated
Show resolved
Hide resolved
5b07c03
to
49ac07d
Compare
49ac07d
to
1bfbbc1
Compare
Builds ready [1bfbbc1]
Page Load Metrics (1686 ± 71 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [889a8f5]
Page Load Metrics (1691 ± 76 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Co-authored-by: Frederik Bolding <[email protected]>
00a2c0b
to
50a0699
Compare
Co-authored-by: Frederik Bolding <[email protected]>
Description
Like with websites, we want to support a custom network per Snap rather than relying on the globally selected network. For Snaps, the permission for the network to switch to is automatically granted.
Blocked by:
wallet_switchEthereumChain
snaps#2634.Todo
selected-network-controller
.Manual testing steps
CHAIN_PERMISSIONS=true
.wallet_switchEthereumChain
in a Snap.Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist