Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: When the other network added following the previous network deletion the app quits, user can't add any network #13352

Open
sleepytanya opened this issue Feb 5, 2025 · 3 comments
Labels
regression-prod-7.38.1 Regression bug that was found in production in release 7.38.1 regression-RC-7.39.0 Regression bug that was found in release candidate (RC) for release 7.39.0 regression-RC-7.40.0 Regression bug that was found in release candidate (RC) for release 7.40.0 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-wallet-api-platform type-bug Something isn't working

Comments

@sleepytanya
Copy link
Contributor

sleepytanya commented Feb 5, 2025

Describe the bug

When a network is removed from the wallet, there appears to be an issue where the dApp permissions are not updated accordingly, resulting in users being unable to add any other network to the dApp - the app quits unexpectedly.

Present in 7.39.0 and in 7.40.0

Related issues:
#13351
#12684
#13327

Expected behavior

Deletion of a network from the wallet triggers correct update in the dApp permissions settings

Screenshots/Recordings

ScreenRecording_02-04-2025.21-17-21_1.1.MP4

Steps to reproduce

  1. Have several networks added to the dApp
  2. Go to the wallet and delete one of the networks
  3. Add another network from the wallet
  4. Navigate back to the dApp
  5. Click 'Add this network'

Error messages or log output

Detection stage

In production (default)

Version

7.38.1(1524)

Build type

None

Device

Samsung S24 Ultra, iPhone 15

Operating system

iOS, Android

Additional context

No response

Severity

No response

@sleepytanya sleepytanya added regression-prod-7.38.1 Regression bug that was found in production in release 7.38.1 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-wallet-ux type-bug Something isn't working labels Feb 5, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Feb 5, 2025
@sleepytanya sleepytanya changed the title [Bug]: When the other network added folloowing the previous network deletion the app quits, user can't add any network [Bug]: When the other network added following the previous network deletion the app quits, user can't add any network Feb 5, 2025
@sleepytanya sleepytanya added release-blocker This bug is blocking the next release Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing and removed Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking labels Feb 5, 2025
@sleepytanya sleepytanya added regression-RC-7.39.0 Regression bug that was found in release candidate (RC) for release 7.39.0 regression-RC-7.40.0 Regression bug that was found in release candidate (RC) for release 7.40.0 labels Feb 5, 2025
@alfeng6
Copy link

alfeng6 commented Feb 6, 2025

Removing a network is quite rare so this shouldn't be a release blocker. Just a highly prioritized bug.

@alfeng6 alfeng6 added Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking and removed Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing release-blocker This bug is blocking the next release labels Feb 6, 2025
@alfeng6
Copy link

alfeng6 commented Feb 6, 2025

cc: @hesterbruikman I'm removing the release blocker label and changing the sev number but please make the final call given it's related to dapps adding networks

@hesterbruikman
Copy link
Contributor

We believe this is an issue with the Permissions Controller not updating on add/remove network. @jiexi I believe we had a similar issue on Extension that has been fixed, fixed by the permittedChain refactoring by Wallet API Platform. Do you recall what the fix was and what's needed to apply this to Mobile?

cc @NidhiKJha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-prod-7.38.1 Regression bug that was found in production in release 7.38.1 regression-RC-7.39.0 Regression bug that was found in release candidate (RC) for release 7.39.0 regression-RC-7.40.0 Regression bug that was found in release candidate (RC) for release 7.40.0 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-wallet-api-platform type-bug Something isn't working
Projects
Status: To be fixed
Development

No branches or pull requests

3 participants