-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
refactor: Replace redesign confirmation BottomModal with BottomSheet #13268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
04a974b
refactor: rm background color form bottom sheet footer and header
digiwand a7c0698
refactor: use BottomSheet for redesign Confirm
digiwand f1defbf
refactor: replace BlockaidBanner style prop uses
digiwand 44837f7
test: update snapshots following BottomSheet updates
digiwand 3605a39
test:fix: redesign Confirm mock SafeAreaProvider
digiwand f9d3150
Revert "refactor: rm background color form bottom sheet footer and he…
digiwand 60757f0
refactor: BottomSheet replace styleAnimatedView -> isBackgroundAltern…
digiwand 50594e4
test:fix: restore BottomSheet header and footer background
digiwand 3c4a247
Merge branch 'main' into refactor-signature-use-bottom-sheet
digiwand 02bbf25
fix: merge conflicts
digiwand 58ec799
test: rm async and update phrases Confirm.test
digiwand a7ea0fe
test: rm unused getAddressAccountType mock Confirm.test
digiwand 52761af
test: rm unnecessary beforeEach clearAllMocks
digiwand 40d16ad
test: Confirm.test add more mocks to remove console.errors
digiwand 07e7f1f
test: Confirm.test rm missing act warning
digiwand 9479133
Merge branch 'main' into refactor-signature-use-bottom-sheet
digiwand 8cd072e
refactor: revert isBackgroundAlternative -> stylesDialogSheet Confir…
digiwand 2605bca
test:fix: bypass lint empty function
digiwand 42a4559
fix: Confirm merge conflicts padding and height
digiwand e76e66a
fix: ConfirmFooter backgroundColor
digiwand b103da4
Merge branch 'main' into refactor-signature-use-bottom-sheet
digiwand b7e45e8
fix: confirm Footer import
digiwand ef8ebc5
Merge branch 'main' into refactor-signature-use-bottom-sheet
digiwand 1c8616d
Merge branch 'main' into refactor-signature-use-bottom-sheet
digiwand e05ec52
fix: merge conflicts rm Confirm scrollView styles
digiwand 52fb72e
fix: confirm scroll centering
digiwand 7634cb5
fix: confirm scroll icon color
digiwand 257462d
fix: confirm scroll performance and log warnings
digiwand 29d0159
fix: snapshots after removal of View + margin
digiwand e7dd4ae
Merge branch 'main' into refactor-signature-use-bottom-sheet
digiwand 1598bba
fix merge
digiwand 8b18399
Merge branch 'main' into refactor-signature-use-bottom-sheet
digiwand 35aa603
merge commit fixes
digiwand 8e9532f
Updated BottomSheetDialog style
brianacnguyen 06d7de3
Merge branch 'main' into refactor-signature-use-bottom-sheet
digiwand b4ba3c3
style: fix indent
digiwand acbdf1d
fix: confirm footer styles
digiwand 580cf91
fix: Footer import LedgerContext
digiwand 41da02c
fix: bottom to top animation
digiwand a61de1c
Merge branch 'main' into refactor-signature-use-bottom-sheet
digiwand 8a7c8ff
Removed unnecessary changes
brianacnguyen 1daf7b0
Merge branch 'main' into refactor-signature-use-bottom-sheet
digiwand 5ea61bf
fix: reintroduce onClose onReject Confirm just in case
digiwand 9ec06d6
fix: missing scroll paddingHorizontal
digiwand 4034da6
refactor: <View> -> <>. TouchableWithoutFeedback needs children elem
digiwand a7c539a
fix: rm flatContainer paddingHorizontal
digiwand File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.