-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Non evm network global selector #13307
Draft
tommasini
wants to merge
14
commits into
main
Choose a base branch
from
feat/non-evm-networks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+12,720
−5,251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… disabled and added TODO for places where non evm network is not supported yet, added feature flag SOLANA_ENABLED that sould be replaced by the code fencing system and should be reviewed, added solana to the network selector, logic to switch network and accounts accordingly to evm an non evm accounts, added solana to network settings
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…nly evm network related data, this way we can be using evm accounts and networks at confirmations and in app browser without worrying about what is being used at the wallet view
…ontroller version
…fix unit tests, remove feature flag, and removed everything from code fence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multichain network controllers selectors, network selectors refactor disabled and added TODO for places where non evm network is not supported yet, added feature flag SOLANA_ENABLED that sould be replaced by the code fencing system and should be reviewed, added solana to the network selector, logic to switch network and accounts accordingly to evm an non evm accounts, added solana to network settings
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist