feat: add initial structure for Alert System #13382
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
| setAlertKey, | ||
| unconfirmedDangerAlerts, | ||
| unconfirmedFieldDangerAlerts, | ||
| ]); |
There was a problem hiding this comment.
Nit: I am not sure if useMemo above is useful.
|
Small thing context needs more text coverage, but may be in PRs to come: 
|
| })); | ||
|
|
||
| describe('AlertsContext', () => { | ||
| const alert1: Alert = { |
There was a problem hiding this comment.
Minor, would it make sense to rename them dangerAlertMock warningAlertMock etc?
| [Severity.Warning]: 2, | ||
| [Severity.Info]: 1, | ||
| }; | ||
| return alerts.sort((a, b) => severityOrder[b.severity] - severityOrder[a.severity]); |
There was a problem hiding this comment.
Would it make sense to avoid mutating alerts array since this is passed by a result of an hook (useConfirmationAlerts)?
| return alerts.sort((a, b) => severityOrder[b.severity] - severityOrder[a.severity]); | |
| return [...alerts].sort((a, b) => severityOrder[b.severity] - severityOrder[a.severity]); |
|
Description
This PR aims to add the initial structure to support the new alert system.
There are no functional changes at this point.
Related issues
Fixes: https://github.com/MetaMask/mobile-planning/issues/2130
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist