Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for ledger wallet in new signature designs #13402

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: Add support for ledger wallet in new signature designs #13402

wants to merge 3 commits into from
+529 −82

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Feb 7, 2025 •
edited
Loading

Description

Add support for ledger signing in new designs.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4073

Manual testing steps

  1. Deploy code on device and connect with ledger
  2. Sign request using ledger account

Screenshots/Recordings

Screen_Recording_20250207_143514_MetaMask.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Feb 7, 2025
Base automatically changed from qr_scan_support to main February 7, 2025 14:17
@jpuri jpuri force-pushed the ledger_int branch 2 times, most recently from 701b6ed to 4150f79 Compare February 11, 2025 10:06
@jpuri jpuri changed the title Add support for ledger wallet in new signature designs feat: Add support for ledger wallet in new signature designs Feb 11, 2025
@jpuri jpuri marked this pull request as ready for review February 11, 2025 13:29
@jpuri jpuri requested review from a team as code owners February 11, 2025 13:29
@MetaMask MetaMask deleted a comment from Rorrote Feb 13, 2025
@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 13, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 528de74
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fc645c26-d686-45f0-998e-1b511d8eba9b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sleepytanya
Copy link
Contributor

Android Release build: https://app.bitrise.io/app/be69d4368ee7e86d/installable-artifacts/416cb3b0aca21891

Screen_Recording_20250213_091750_MetaMask.mp4

@sleepytanya
Copy link
Contributor

@jpuri

New designs - buttons are too low again:

Screen_Recording_20250213_104957_MetaMask.mp4

@jpuri
Copy link
Contributor Author

jpuri commented Feb 13, 2025

Hey @sleepytanya : footer buttons position is not changed in this PR.

@sleepytanya
Copy link
Contributor

@jpuri

main build https://app.bitrise.io/build/99e75b46-f7f4-4403-8395-c2b9226c2f6f?tab=artifacts

Old design looks normal:

Screen_Recording_20250213_200638_MetaMask.mp4

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
88.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 14, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 14, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f901d0c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9c8cf358-5c58-4891-b78f-6721768a2f90

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sleepytanya sleepytanya added the QA Passed A successful QA run through has been done label Feb 14, 2025
@sleepytanya
Copy link
Contributor

Misplaced Android buttons issues is not related to the current PR, it is an issue on main:
#13516

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpuri @sleepytanya @metamaskbot