test: Modify Stake smoke test not to use default test account for funding #13458
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
davibroc
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13458 +/- ##
==========================================
+ Coverage 61.58% 61.86% +0.27%
==========================================
Files 1953 1974 +21
Lines 43442 43834 +392
Branches 5835 5916 +81
==========================================
+ Hits 26753 27116 +363
- Misses 14905 14919 +14
- Partials 1784 1799 +15 ☔ View full report in Codecov by Sentry. |
|
|
davibroc
force-pushed
the
test/stake-tests-fix
branch
from
8f4fb50 to
a65f877
Compare
| await AccountListBottomSheet.tapAddAccountButton(); | ||
| await AddAccountBottomSheet.tapImportAccount(); | ||
| await Assertions.checkIfVisible(ImportAccountView.container); | ||
| await ImportAccountView.enterPrivateKey(process.env.MM_STAKE_TEST_ACCOUNT_PRIVATE_KEY); |
There was a problem hiding this comment.
Might be a good idea to add this variable in the .js.env.example file as well.
Description
This is a solution for preventing somebody from draining holesky ETH from our test account as the SRP is currently exposed. Basically the stake account containing the Holesky ETH is now imported from the ENV variable
MM_STAKE_TEST_ACCOUNT_PRIVATE_KEYcontaining the PK of the account. To run the tests locally engineers will need to set the value found 1Password and add it to.js.envI also reduced the amount of ETH used for staking as requested by the stake team
Related issues
Fixes:
#13433
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist